fix: incorrect table data disk cache key #16837
Merged
+31
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Range
returned by merged reading should not be used as the corresponding parts of table data cache key,instead
offset
andlen
of column meta should be used.range.start
is not stable and can vary for the same column depending on the query's projection.For instance:
SELECT col1, col2 FROM t;
SELECT col2 FROM t;
may result in different ranges for
col2
, this can lead to cache missing or INCONSISTENCIESTests
Type of change
This change is